Skip to content

Revert "Add Unit Tests for Upload Service" #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

neslihanturan
Copy link
Collaborator

Reverts #4322 since it breaks tests

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #4353 (5189e12) into master (c269693) will decrease coverage by 0.07%.
The diff coverage is 3.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4353      +/-   ##
============================================
- Coverage     10.30%   10.22%   -0.08%     
+ Complexity      471      469       -2     
============================================
  Files           342      342              
  Lines         13145    13084      -61     
  Branches       1063     1062       -1     
============================================
- Hits           1354     1338      -16     
+ Misses        11723    11678      -45     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...n/java/fr/free/nrw/commons/CommonsApplication.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/fr/free/nrw/commons/auth/SessionManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/free/nrw/commons/bookmarks/BookmarkFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/fr/free/nrw/commons/contributions/ChunkInfo.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../commons/contributions/ContributionController.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ree/nrw/commons/contributions/ContributionDao.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...w/commons/contributions/ContributionsContract.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...w/commons/contributions/ContributionsFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ns/contributions/ContributionsLocalDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...commons/contributions/ContributionsRepository.java 41.66% <0.00%> (-3.79%) 3.00 <0.00> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba7fb8...5189e12. Read the comment docs.

@misaochan misaochan merged commit 4bca142 into master Apr 12, 2021
@ashishkumar468 ashishkumar468 deleted the revert-4322-uploadservicetests branch April 12, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants