READ_EXTERNAL_STORAGE permission is not necessary while picking file from gallery #4356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neslihanturan
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3744
What changes did you make and why?
As READ_EXTERNAL_STORAGE permission isn't required for picking an image from the gallery. So if storage permission is turned off app should not show a dialog to turn on the permission for READ_EXTERNAL_STORAGE.
Tests performed
Tested 3.0.0-debug-master on Pixel 4 with API level 27 and OPPO A57 with API level 23
Screenshots (for UI changes only)
Permission is turned off.
permission_.mp4