Fixes #4358 Remind the user to turn on the network#4377
Closed
obsidian-zero wants to merge 6 commits intocommons-app:masterfrom
Closed
Fixes #4358 Remind the user to turn on the network#4377obsidian-zero wants to merge 6 commits intocommons-app:masterfrom
obsidian-zero wants to merge 6 commits intocommons-app:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4377 +/- ##
============================================
- Coverage 10.31% 10.31% -0.01%
Complexity 476 476
============================================
Files 342 342
Lines 13104 13108 +4
Branches 1072 1073 +1
============================================
Hits 1352 1352
- Misses 11685 11689 +4
Partials 67 67
Continue to review full report at Codecov.
|
neslihanturan
requested changes
May 10, 2021
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
This will show this warning every time when a user uploads things. We don't want this. What we want is checking if the network is connected and if not displaying this warning. You can simply check where we already implemented the related toast message and display a warning instead of toast.
Clear CompositeDisposable after logging in successfully. It may help solve the problem of saving the contribution to the previous account
This reverts commit b1b4257.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Fixes #4358
A infoAlert has been added to alert users to their network connections.