Skip to content

Added an option to Remove a new language description while uploading #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2021

Conversation

Ayan-10
Copy link
Contributor

@Ayan-10 Ayan-10 commented May 10, 2021

Description

Fixes #2810

What changes did you make and why?

Sometimes, a user might accidentally click the "+" button for adding a new language while uploading an image, there was no option to remove it in the current app. So I added a remove button so that the user can remove it.

Tests performed

Tested 3.0.0-lastest master on Pixel 4 with API level 27.

Screenshots

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great!
Just a javadoc request.
It reduces vertical space to view the picture when writing metadata, but I guess that's unavoidable.

@Ayan-10
Copy link
Contributor Author

Ayan-10 commented May 14, 2021

@nicolas-raoul I added java docs. Hope it's up to the mark now.

@Ayan-10 Ayan-10 requested a review from nicolas-raoul May 14, 2021 14:07
@codecov-commenter
Copy link

Codecov Report

Merging #4406 (e5532b6) into master (e9069d0) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4406      +/-   ##
============================================
+ Coverage     10.30%   10.38%   +0.07%     
- Complexity      476      479       +3     
============================================
  Files           342      342              
  Lines         13114    13154      +40     
  Branches       1074     1074              
============================================
+ Hits           1352     1366      +14     
- Misses        11695    11719      +24     
- Partials         67       69       +2     
Impacted Files Coverage Δ Complexity Δ
...e/nrw/commons/upload/UploadMediaDetailAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...upload/mediaDetails/UploadMediaDetailFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fr/free/nrw/commons/category/ContinuationClient.kt 89.47% <0.00%> (-10.53%) 11.00% <0.00%> (ø%)
...mons/contributions/ContributionBoundaryCallback.kt 88.00% <0.00%> (-7.46%) 6.00% <0.00%> (ø%)
...main/java/fr/free/nrw/commons/media/MediaClient.kt 88.09% <0.00%> (-2.15%) 17.00% <0.00%> (ø%)
...mons/upload/mediaDetails/UploadMediaPresenter.java 54.28% <0.00%> (-1.60%) 15.00% <0.00%> (ø%)
...in/java/fr/free/nrw/commons/data/DBOpenHelper.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/java/fr/free/nrw/commons/upload/UploadItem.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...fr/free/nrw/commons/media/MediaDetailFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9069d0...e5532b6. Read the comment docs.

@nicolas-raoul nicolas-raoul merged commit a78fea0 into commons-app:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Remove a new language description while uploading
3 participants