-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added an option to Remove a new language description while uploading #4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great!
Just a javadoc request.
It reduces vertical space to view the picture when writing metadata, but I guess that's unavoidable.
app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java
Show resolved
Hide resolved
@nicolas-raoul I added java docs. Hope it's up to the mark now. |
Codecov Report
@@ Coverage Diff @@
## master #4406 +/- ##
============================================
+ Coverage 10.30% 10.38% +0.07%
- Complexity 476 479 +3
============================================
Files 342 342
Lines 13114 13154 +40
Branches 1074 1074
============================================
+ Hits 1352 1366 +14
- Misses 11695 11719 +24
- Partials 67 69 +2
Continue to review full report at Codecov.
|
Description
Fixes #2810
What changes did you make and why?
Sometimes, a user might accidentally click the "+" button for adding a new language while uploading an image, there was no option to remove it in the current app. So I added a remove button so that the user can remove it.
Tests performed
Tested 3.0.0-lastest master on Pixel 4 with API level 27.
Screenshots