Skip to content

added bookmarkLocationFragment unit tests #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2021

Conversation

4D17Y4
Copy link
Contributor

@4D17Y4 4D17Y4 commented May 10, 2021

Description (required)
Added BookmarkLocationFragmentUnitTests.

Tests performed (required)
Tested betaDebug on Nokia 6.1+ with API level 29.

@4D17Y4
Copy link
Contributor Author

4D17Y4 commented May 10, 2021

Up for review.
@nicolas-raoul , @madhurgupta10

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #4407 (1feb337) into master (e9069d0) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4407      +/-   ##
============================================
+ Coverage     10.30%   10.38%   +0.07%     
- Complexity      476      479       +3     
============================================
  Files           342      342              
  Lines         13114    13154      +40     
  Branches       1074     1074              
============================================
+ Hits           1352     1366      +14     
- Misses        11695    11719      +24     
- Partials         67       69       +2     
Impacted Files Coverage Δ Complexity Δ
...fr/free/nrw/commons/category/ContinuationClient.kt 89.47% <0.00%> (-10.53%) 11.00% <0.00%> (ø%)
...mons/contributions/ContributionBoundaryCallback.kt 88.00% <0.00%> (-7.46%) 6.00% <0.00%> (ø%)
...main/java/fr/free/nrw/commons/media/MediaClient.kt 88.09% <0.00%> (-2.15%) 17.00% <0.00%> (ø%)
...mons/upload/mediaDetails/UploadMediaPresenter.java 54.28% <0.00%> (-1.60%) 15.00% <0.00%> (ø%)
...in/java/fr/free/nrw/commons/data/DBOpenHelper.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/java/fr/free/nrw/commons/upload/UploadItem.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...fr/free/nrw/commons/media/MediaDetailFragment.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...e/nrw/commons/upload/UploadMediaDetailAdapter.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/fr/free/nrw/commons/quiz/RadioGroupHelper.java 68.42% <0.00%> (+68.42%) 3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9069d0...1feb337. Read the comment docs.

@madhurgupta10
Copy link
Collaborator

@4D17Y4 can you post a screenshot of code coverage report for this class?

@4D17Y4
Copy link
Contributor Author

4D17Y4 commented May 12, 2021

image
@madhurgupta10 screenshot of code coverage.
Thanks.

@madhurgupta10
Copy link
Collaborator

@4D17Y4 can you export this report and share a screenshot of the file where we can see lines hit/miss. Thanks!

@4D17Y4
Copy link
Contributor Author

4D17Y4 commented May 15, 2021

image
image

Here are the screenshots @madhurgupta10
I'm not sure what u mean by exporting this report, should I send the HTML script of the report?

@madhurgupta10
Copy link
Collaborator

I'm not sure what u mean by exporting this report, should I send the HTML script of the report?

The screenshot is fine, Thanks

Will it be possible to cover few more missed lines?

@4D17Y4
Copy link
Contributor Author

4D17Y4 commented May 15, 2021

image
image
image

Added some tests @madhurgupta10

@madhurgupta10
Copy link
Collaborator

@4D17Y4 Thanks, good coverage!

@madhurgupta10 madhurgupta10 merged commit 9562fd1 into commons-app:master May 15, 2021
@4D17Y4 4D17Y4 deleted the bookmarkLocationFragmentTest branch June 22, 2021 09:31
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this pull request Jul 5, 2021
* added bookmarkLocationFragment unit tests

* more lines covered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants