New review layout UI for landscape view #4412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4412 +/- ##
=========================================
Coverage 10.38% 10.38%
Complexity 479 479
=========================================
Files 342 342
Lines 13154 13154
Branches 1074 1074
=========================================
Hits 1366 1366
Misses 11719 11719
Partials 69 69 Continue to review full report at Codecov.
|
|
@madhurgupta10 @nicolas-raoul up for review. |
There was a problem hiding this comment.
I get this crash everytime I start review in landscape mode, or rotate the screen to landscape on the review activity. Any idea?
05-14 19:26:14.138 20497 20497 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{fr.free.nrw.commons/fr.free.nrw.commons.review.ReviewActivity}: java.lang.IllegalStateException: Required view 'mediaDetailContainer' with ID 2131296619 for field 'mediaDetailContainer' was not found. If this view is optional add '@Nullable' (fields) or '@Optional' (methods) annotation.
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3107)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3250)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1947)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:106)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.os.Looper.loop(Looper.java:214)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7032)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
05-14 19:26:14.138 20497 20497 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
This seems related to ButterKnife BindViews, @Ayan-10 can you cross-check if both portrait and landscape layout contain all the ids? |
|
Sorry for the inconvenience. @madhurgupta10 @nicolas-raoul I tested the app several times before the PR. Now I rechecked it also. But there is no crash in my emulator as you can see in the screenshot. @madhurgupta10 I don't think the issue is related to not containing IDs. Otherwise, It will crash on my emulator also and I am sure both portrait and landscape layout contain all the ids. Screenshot was taken: 6.41 IST
|
|
@nicolas-raoul @madhurgupta10 But as you are saying the app is crashing on your device. I will try to find the problem as soon as possible and let you know about it. Can you provide me the device API number in which you tested the app? Thank you. |
|
Thanks! I am on Android version 9. |
|
@nicolas-raoul It's still not crashing any of my devices. I assumed the issue and did some modifications. Can you please recheck it on your device? |
|
I just tested your PR, on my side, I don't have any crashes for both beta and prod. |
|
It still crashes very consistently on my device, even after removing the app's data. |
|
As I can see in the log, There is a But I get it @nicolas-raoul @madhurgupta10 . Someone added some code in the review layout very recently. So that part of the code was not present in my local repo. This is the reason for not crashing in my device and @madhurgupta10 's device because we don't have the very recent changes in our repo. I will fix it as soon as possible. |
|
@nicolas-raoul @madhurgupta10 Hope now it's not crashing. |
nicolas-raoul
approved these changes
May 15, 2021
|
It works great now, thanks! :-) |
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Jul 5, 2021
* ReviewActivity landscape layout created successfully * Minor issues fixed * minor modification * crash fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4343
What changes did you make and why?
Elements of ReviewActivity is not visible to user in landscape. I made a different landscape UI for it.
Tests performed (required)
Tested 3.0.0-latest master on Pixel 4 with API level 27.
Screenshots (for UI changes only)