Skip to content

UploadMediaDetail: replace discreet error toast with more-noticeable dialog #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

byerlyb20
Copy link
Contributor

Description (required)

Fixes #4358

  • Add new string resources for connection error dialog title and description
  • Add new showConnectionErrorPopup() method to UploadMediaDetailContract
  • Implement showConnectionErrorPopup() in UploadMediaDetailFragment to launch an alert dialog
  • Call showConnectionErrorPopup() from UploadMediaPresenter when image quality verification fails with an UnknownHostException

Tests performed (required)

Tested betaDebug on Pixel 4 XL with API level 30.

Screenshots (for UI changes only)

Screenshot_1622495244

@codecov-commenter
Copy link

Codecov Report

Merging #4433 (31b47a3) into master (7db6f83) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4433      +/-   ##
============================================
- Coverage     10.34%   10.30%   -0.05%     
- Complexity      479      482       +3     
============================================
  Files           342      343       +1     
  Lines         13201    13251      +50     
  Branches       1083     1090       +7     
============================================
- Hits           1366     1365       -1     
- Misses        11766    11815      +49     
- Partials         69       71       +2     
Impacted Files Coverage Δ
...upload/mediaDetails/UploadMediaDetailFragment.java 0.00% <0.00%> (ø)
...mons/upload/mediaDetails/UploadMediaPresenter.java 53.27% <0.00%> (-1.02%) ⬇️
...rw/commons/wikidata/WikidataDisambiguationItems.kt 50.00% <0.00%> (-50.00%) ⬇️
...ree/nrw/commons/upload/depicts/DepictsPresenter.kt 72.54% <0.00%> (-19.76%) ⬇️
...rc/main/java/fr/free/nrw/commons/db/AppDatabase.kt 0.00% <0.00%> (ø)
...c/main/java/fr/free/nrw/commons/db/Converters.java 0.00% <0.00%> (ø)
...n/java/fr/free/nrw/commons/upload/UploadModel.java 0.00% <0.00%> (ø)
.../free/nrw/commons/di/CommonsApplicationModule.java 0.00% <0.00%> (ø)
...ee/nrw/commons/upload/depicts/DepictsFragment.java 0.00% <0.00%> (ø)
...ommons/upload/structure/depictions/DepictedItem.kt 88.67% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db6f83...31b47a3. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @byerlyb20 , it is nicely written and works as intended. Additionally, congratz for your first contribution, welcome! 🥳

@neslihanturan neslihanturan merged commit 165c375 into commons-app:master Jun 4, 2021
@byerlyb20 byerlyb20 deleted the network-reminder branch June 4, 2021 14:31
ashishkumar468 pushed a commit to ashishkumar468/apps-android-commons that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remind the user to turn on the network
3 participants