Cahnge gallery icon color if it is on overlay menu

[neslihanturan]

Fixes point 1 of #442 .
If you suggest a more clear way to solve, I would be appreciated.

[veyndan]

How about something like this?

[domdomegg]

@veyndan That's changing the color based off the theme, we need to change the color depending on whether it is in the overflow menu or not

i.e. it should still be white in the light theme if in the action bar rather than the menu

[neslihanturan]

@veyndan Actually, our icon colors are already set with the method in stackoverflow post you showed. But it wouldn't work in our case. We need to detect if icon is on overlay menu or not. If so, we should set the icon color to reverse of current theme required.

[veyndan]

Oops sorry I misunderstood the problem. Thanks for the clarifications!

[veyndan]

Here's a suggestion that may work. If we use a Toolbar instead of the ActionBar then we can specify the theme specifically for the popup menu via popupTheme. Here we can change the icon to the opposite icon. I'll give it a go.

I think this'll require using Toolbar's across the app, so I'll just make a separate PR for that.

[veyndan]

It appears that we aren't using AppCompatActivity consistently throughout the codebase, so I need to convert that before working on the rest.

If we need this solution straight away then I guess it'd be fine to merge and then a better solution can replace it later on. I don't know how urgent this is.

[misaochan]

Unless there are objections, I would go with merging as soon as possible, so we can get the new UI into beta on schedule.

[veyndan]

Having a hardcoded value of 360 to check if there is enough room for two icons feels a bit hacky, but this will be solved in a later commit. Apparently time is of the essence, so thanks for the speedy fix!