[GSoC] Welcome Dialog #4546
Merged
[GSoC] Welcome Dialog #4546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Aug 12, 2021
nicolas-raoul
requested changes
Aug 12, 2021
There was a problem hiding this comment.
In landscape mode on my phone, the "Awesome" button is hidden, and I can't scroll down to it. The "Back" button does not work either, so I am effectively stuck on that dialog and have to kill the app.
Maybe let the user scroll if the screen height is too small? And implement "Back"?
nicolas-raoul
approved these changes
Aug 14, 2021
4D17Y4
added a commit
to 4D17Y4/apps-android-commons
that referenced
this pull request
Aug 18, 2021
* Welcome Dialog * Condition Fix * Orientation, back button Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added welcome dialog on first custom selector launch.