Skip to content

Disabling the managed exifs tab if the user isn't logged in #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeremybowenn
Copy link
Contributor

@jeremybowenn jeremybowenn commented Aug 25, 2021

Disabling the managed exifs tab if the user isn't logged in

Fixes #4501

Added the exif to the list of preferences being disabled on creation

Skipped log in and verified the component was disabled. Logged and verified the component worked.

Tested ProdDebug on Pixel 5 API 28

exifs-disabled
exifs-enabled

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct, we can merge this as soon as conflicts are fixed :) Thanks for the PR!

# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java
@jeremybowenn
Copy link
Contributor Author

Merged master. Should be good!

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeremybowenn :)

@neslihanturan neslihanturan merged commit 07bf708 into commons-app:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only logged in users should be able to see manage EXIF tags setting
2 participants