Skip to content

Bug fix- current location marker #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Bug fix- current location marker #4580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ public void enableFABRecenter() {
public void addCurrentLocationMarker(final fr.free.nrw.commons.location.LatLng curLatLng) {
if (null != curLatLng && !isPermissionDenied) {
ExecutorUtils.get().submit(() -> {
removeCurrentLocationMarker();
mapView.post(() -> removeCurrentLocationMarker());
Timber.d("Adds current location marker");

final Icon icon = IconFactory.getInstance(getContext())
Expand All @@ -1194,7 +1194,8 @@ public void addCurrentLocationMarker(final fr.free.nrw.commons.location.LatLng c
.position(new LatLng(curLatLng.getLatitude(),
curLatLng.getLongitude()));
currentLocationMarkerOptions.setIcon(icon); // Set custom icon
currentLocationMarker = mapBox.addMarker(currentLocationMarkerOptions);
mapView.post(
() -> currentLocationMarker = mapBox.addMarker(currentLocationMarkerOptions));

final List<LatLng> circle = UiUtils
.createCircleArray(curLatLng.getLatitude(), curLatLng.getLongitude(),
Expand All @@ -1204,8 +1205,9 @@ public void addCurrentLocationMarker(final fr.free.nrw.commons.location.LatLng c
.addAll(circle)
.strokeColor(getResources().getColor(R.color.current_marker_stroke))
.fillColor(getResources().getColor(R.color.current_marker_fill));
currentLocationPolygon = mapBox.addPolygon(currentLocationPolygonOptions);

mapView.post(
() -> currentLocationPolygon = mapBox
.addPolygon(currentLocationPolygonOptions));
});
} else {
Timber.d("not adding current location marker..current location is null");
Expand Down