Skip to content

Codecov Uploader Update #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

madhurgupta10
Copy link
Collaborator

@madhurgupta10 madhurgupta10 commented Oct 14, 2021

Description
I received an email from codecov that bash uploader will be deprecating and in the meantime there will be occasional outages (https://docs.codecov.com/docs/about-the-codecov-bash-uploader)

So I have updated to the new uploader

I have also updated jacoco filter to exclude the complete di folder

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #4673 (7a12482) into master (fa3c172) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4673      +/-   ##
============================================
+ Coverage     38.81%   38.87%   +0.05%     
+ Complexity     1673     1668       -5     
============================================
  Files           347      353       +6     
  Lines         14447    14695     +248     
  Branches       1285     1284       -1     
============================================
+ Hits           5608     5712     +104     
- Misses         8439     8583     +144     
  Partials        400      400              
Impacted Files Coverage Δ
...ons/explore/categories/PageableCategoryFragment.kt 50.00% <0.00%> (-10.00%) ⬇️
...ava/fr/free/nrw/commons/category/CategoryClient.kt 75.00% <0.00%> (-6.82%) ⬇️
...nrw/commons/customselector/database/UploadedDao.kt 33.33% <0.00%> (-6.67%) ⬇️
...tomselector/ui/selector/CustomSelectorViewModel.kt 87.50% <0.00%> (-4.17%) ⬇️
...ntributions/WikipediaInstructionsDialogFragment.kt 17.64% <0.00%> (-3.79%) ⬇️
...explore/depictions/media/DepictedImagesFragment.kt 16.66% <0.00%> (-3.34%) ⬇️
...xplore/categories/media/CategoriesMediaFragment.kt 16.66% <0.00%> (-3.34%) ⬇️
...nrw/commons/explore/media/PageableMediaFragment.kt 14.28% <0.00%> (-3.11%) ⬇️
...va/fr/free/nrw/commons/category/CategoriesModel.kt 49.01% <0.00%> (-3.07%) ⬇️
...fr/free/nrw/commons/category/ContinuationClient.kt 86.95% <0.00%> (-3.05%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3c172...7a12482. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhurgupta10 :)

@neslihanturan neslihanturan merged commit 52b05f7 into commons-app:master Oct 14, 2021
@madhurgupta10 madhurgupta10 deleted the cifix branch October 15, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants