Skip to content

Add CommonPlaceClickActions Unit Tests #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

madhurgupta10
Copy link
Collaborator

Description
Add CommonPlaceClickActions Unit Tests, some code is refactored to account for maximum code coverage for this class.

Tests performed
Tested ProdDebug on Google Pixel 2 with API level 2

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #4674 (4124709) into master (401f70c) will increase coverage by 0.11%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4674      +/-   ##
============================================
+ Coverage     38.85%   38.96%   +0.11%     
- Complexity     1666     1670       +4     
============================================
  Files           353      353              
  Lines         14695    14697       +2     
  Branches       1284     1284              
============================================
+ Hits           5710     5727      +17     
+ Misses         8586     8571      -15     
  Partials        399      399              
Impacted Files Coverage Δ
...ommons/nearby/fragments/CommonPlaceClickActions.kt 51.78% <88.88%> (+29.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401f70c...4124709. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhurgupta10 :)

@neslihanturan neslihanturan merged commit d1bf6d0 into commons-app:master Dec 6, 2021
@madhurgupta10 madhurgupta10 deleted the commonactiontest branch December 11, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants