Skip to content

Increased number of leaderboard records fetched in a single request from API #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

AyusmaTech
Copy link
Contributor

Description (required)

Fixes #4372

What changes did you make and why?
Increased number of leaderboard records fetched in a single request from API

Tests performed (required)

Tested ProdDebug on Pixel 4 XL with API level 31.

Fixes commons-app#4372

What changes did you make and why?
Increased number of leaderboard records fetched in a single request from API

**Tests performed (required)**

Tested ProdDebug on Pixel 4 XL with API level 31.
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #4697 (511be58) into master (eb8882a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4697      +/-   ##
============================================
- Coverage     39.50%   39.50%   -0.01%     
  Complexity     1697     1697              
============================================
  Files           354      354              
  Lines         14878    14878              
  Branches       1281     1281              
============================================
- Hits           5878     5877       -1     
- Misses         8584     8585       +1     
  Partials        416      416              
Impacted Files Coverage Δ
...mons/profile/leaderboard/LeaderboardConstants.java 0.00% <ø> (ø)
...w/commons/contributions/ContributionsFragment.java 31.27% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8882a...511be58. Read the comment docs.

Copy link
Collaborator

@madhurgupta10 madhurgupta10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AyusmaTech :)

@madhurgupta10 madhurgupta10 merged commit e297f6c into commons-app:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase number of leaderboard records fetched in a single request from API
2 participants