Skip to content

Fixes #4682 - Removed read_phone_state_permission #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #4682

What changes did you make and why?
Followed this -mapbox/mapbox-navigation-android#3577 to include relevant dependency which fixes the phone state permission

Tests performed (required)

Tested betaDebug on API 30

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #4723 (55a56bc) into master (d1bf6d0) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4723      +/-   ##
============================================
+ Coverage     39.65%   39.68%   +0.03%     
  Complexity     1731     1731              
============================================
  Files           357      357              
  Lines         15170    15160      -10     
  Branches       1306     1303       -3     
============================================
+ Hits           6015     6016       +1     
+ Misses         8727     8717      -10     
+ Partials        428      427       -1     
Impacted Files Coverage Δ
...r/free/nrw/commons/contributions/MainActivity.java 74.28% <0.00%> (+4.01%) ⬆️
...r/free/nrw/commons/explore/media/MediaConverter.kt 92.85% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bf6d0...55a56bc. Read the comment docs.

@ashishkumar468
Copy link
Collaborator Author

Codecov path is failing because it treats modifications to existing lines as new lines.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ashishkumar468 :)

@neslihanturan
Copy link
Collaborator

I have tested this on both emulator and physical device and it works, thanks @ashishkumar468 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App requests READ_PHONE_STATE permission for map
2 participants