Fix warnings for ImageFileLoader.kt #4786 #4789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4789 +/- ##
============================================
- Coverage 42.17% 42.03% -0.15%
+ Complexity 1888 1878 -10
============================================
Files 364 364
Lines 15735 15734 -1
Branches 1361 1361
============================================
- Hits 6637 6613 -24
- Misses 8610 8632 +22
- Partials 488 489 +1
Continue to review full report at Codecov.
|
| @@ -82,7 +82,7 @@ class ImageFileLoader(val context: Context) : CoroutineScope{ | |||
|
|
|||
|
|
|||
| if (file != null && file.exists()) { | |||
| if (id != null && name != null && path != null && bucketId != null && bucketName != null) { | |||
| if (name != null && path != null && bucketName != null) { | |||
There was a problem hiding this comment.
What warning does this fix? Are you sure there are no side effects? Thanks!
There was a problem hiding this comment.
This fixes the warning which shows
Condition 'id != null' is always 'true'
Condition 'bucketId != null' is always 'true'
there is no harm removing them
nicolas-raoul
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings for ImageFileLoader.kt Fixes #4786
All warning solved except :- 'DATA: String' is deprecated. Deprecated in Java
because solveing this will require major code changes which is probably not necessary at this point of time