Skip to content

Fixes : #4273 Add link to user guide in About #4882

Merged
4D17Y4 merged 3 commits intocommons-app:masterfrom
Rishavgupta12345:guide_in_about
Mar 20, 2022
Merged

Fixes : #4273 Add link to user guide in About #4882
4D17Y4 merged 3 commits intocommons-app:masterfrom
Rishavgupta12345:guide_in_about

Conversation

@Rishavgupta12345
Copy link
Contributor

Fixes: #4273 Add a link to the user guide in About

screen short:
Screenshot 2022-03-07 193720

Copy link
Contributor Author

@Rishavgupta12345 Rishavgupta12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added @madhurgupta10 @4D17Y4

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #4882 (9d959d3) into master (824a82a) will increase coverage by 0.25%.
The diff coverage is 65.45%.

❗ Current head 9d959d3 differs from pull request most recent head 2e92669. Consider uploading reports for the commit 2e92669 to get more accurate results

@@             Coverage Diff              @@
##             master    #4882      +/-   ##
============================================
+ Coverage     50.34%   50.59%   +0.25%     
- Complexity     2210     2230      +20     
============================================
  Files           338      338              
  Lines         15558    15603      +45     
  Branches       1360     1370      +10     
============================================
+ Hits           7832     7895      +63     
+ Misses         7141     7112      -29     
- Partials        585      596      +11     
Impacted Files Coverage Δ
...ommons/customselector/ui/selector/ImageFragment.kt 57.14% <0.00%> (-2.86%) ⬇️
...mmons/customselector/ui/selector/FolderFragment.kt 68.18% <20.00%> (-6.18%) ⬇️
...r/free/nrw/commons/contributions/MainActivity.java 74.72% <60.00%> (-1.28%) ⬇️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 57.34% <70.58%> (+10.05%) ⬆️
...r/free/nrw/commons/explore/media/MediaConverter.kt 71.11% <75.00%> (-0.32%) ⬇️
...r/free/nrw/commons/review/ReviewImageFragment.java 31.68% <80.00%> (+5.87%) ⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java 74.39% <100.00%> (+1.31%) ⬆️
app/src/main/java/fr/free/nrw/commons/Media.kt 57.89% <100.00%> (+1.13%) ⬆️
...a/fr/free/nrw/commons/review/ReviewController.java 79.06% <0.00%> (-4.66%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd61128...2e92669. Read the comment docs.

Copy link
Contributor

@4D17Y4 4D17Y4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@Rishavgupta12345 Rishavgupta12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests added @madhurgupta10 @4D17Y4

@Rishavgupta12345
Copy link
Contributor Author

as it is approved so please merge it

@4D17Y4 4D17Y4 merged commit 6ea3198 into commons-app:master Mar 20, 2022
@4D17Y4
Copy link
Contributor

4D17Y4 commented Mar 20, 2022

Thanks @Rishavgupta12345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link to user guide in About

3 participants