Skip to content

Review category issues#4897

Merged
nicolas-raoul merged 11 commits intocommons-app:masterfrom
devarsh-mavani-19:review_category_issues
Mar 17, 2022
Merged

Review category issues#4897
nicolas-raoul merged 11 commits intocommons-app:masterfrom
devarsh-mavani-19:review_category_issues

Conversation

@devarsh-mavani-19
Copy link
Contributor

Description (required)
In peer review, If a picture has no category, then we already know the answer: The picture is not well-categorized.
In such cases, we could skip that step.

Fixes #4776

What changes did you make and why?
I checked if category exist then show that screen else skip that step
Tests performed (required)
Build Variant: ProdDebug
Device: Redmi 6 Pro

@devarsh-mavani-19
Copy link
Contributor Author

@nicolas-raoul I created different branch as you suggested. Can you please review this. Thanks

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #4897 (622bc74) into master (7bc78f6) will increase coverage by 0.06%.
The diff coverage is 75.75%.

❗ Current head 622bc74 differs from pull request most recent head afb7242. Consider uploading reports for the commit afb7242 to get more accurate results

@@             Coverage Diff              @@
##             master    #4897      +/-   ##
============================================
+ Coverage     50.51%   50.58%   +0.06%     
- Complexity     2225     2226       +1     
============================================
  Files           338      338              
  Lines         15573    15599      +26     
  Branches       1364     1370       +6     
============================================
+ Hits           7866     7890      +24     
+ Misses         7117     7111       -6     
- Partials        590      598       +8     
Impacted Files Coverage Δ
...ava/fr/free/nrw/commons/review/ReviewActivity.java 57.34% <70.58%> (+10.05%) ⬆️
...r/free/nrw/commons/explore/media/MediaConverter.kt 71.11% <75.00%> (-0.32%) ⬇️
...r/free/nrw/commons/review/ReviewImageFragment.java 31.68% <80.00%> (+5.87%) ⬆️
app/src/main/java/fr/free/nrw/commons/Media.kt 57.89% <100.00%> (+1.13%) ⬆️
.../nrw/commons/category/CategoryContentProvider.java 12.50% <0.00%> (-14.29%) ⬇️
...w/commons/upload/categories/BaseDelegateAdapter.kt 35.29% <0.00%> (-11.77%) ⬇️
...va/fr/free/nrw/commons/category/CategoriesModel.kt 57.62% <0.00%> (-1.70%) ⬇️
...ns/upload/categories/UploadCategoriesFragment.java 86.95% <0.00%> (-1.45%) ⬇️
...a/fr/free/nrw/commons/review/ReviewController.java 91.86% <0.00%> (+4.65%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc78f6...afb7242. Read the comment docs.

@nicolas-raoul
Copy link
Member

Code and coverage looking good to me! :-)

When testing it works fine in both cases (categories, no categories).

As seen below I discovered a bug where the "Yes" and "No" buttons are both disabled and never become enabled in the previous step. This bug might exist in master already, but by any chance, can you imagine anything in this PR that might be the cause?
adb

@devarsh-mavani-19
Copy link
Contributor Author

Code and coverage looking good to me! :-)

When testing it works fine in both cases (categories, no categories).

As seen below I discovered a bug where the "Yes" and "No" buttons are both disabled and never become enabled in the previous step. This bug might exist in master already, but by any chance, can you imagine anything in this PR that might be the cause? adb

@nicolas-raoul I verified all files I change. I haven't changed anything inflow of applications. disable & enable button calls are as it was previously. so probably this PR doesn't cause this issue. But I can take a look at it if I am able to reproduce it again. Thanks : )

@nicolas-raoul
Copy link
Member

Understood, thanks for this great PR! :-)

@nicolas-raoul nicolas-raoul merged commit 103e2d5 into commons-app:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Peer review: Do not ask to review categories if there are none

2 participants