Fixes [Bug]: Prod/beta flavor messages may be nonsense for users #4850#4899
Merged
4D17Y4 merged 3 commits intocommons-app:masterfrom Mar 20, 2022
Merged
Fixes [Bug]: Prod/beta flavor messages may be nonsense for users #4850#48994D17Y4 merged 3 commits intocommons-app:masterfrom
4D17Y4 merged 3 commits intocommons-app:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4899 +/- ##
============================================
+ Coverage 50.59% 50.63% +0.03%
- Complexity 2228 2231 +3
============================================
Files 338 338
Lines 15599 15599
Branches 1370 1370
============================================
+ Hits 7892 7898 +6
+ Misses 7114 7105 -9
- Partials 593 596 +3
Continue to review full report at Codecov.
|
4D17Y4
suggested changes
Mar 17, 2022
app/src/main/res/values/strings.xml
Outdated
| <string name="feedback_sharing_data_alert">Please remove from this email any information that you are not comfortable sharing publicly. Also, please be aware that your email address with which you are posting, and the associated name and profile picture, will be visible publicly.</string> | ||
| <string name="achievements_unavailable_beta">Achievements are only available in the prod flavor.</string> | ||
| <string name="leaderboard_unavailable_beta">The leaderboard is only available in the prod flavor.</string> | ||
| <string name="achievements_unavailable_beta">Achievements are only available in the prod flavor,Please check the developer documentation.</string> |
Contributor
There was a problem hiding this comment.
space after comma and small p.
Contributor
Author
Rishavgupta12345
left a comment
There was a problem hiding this comment.
done the changes @4D17Y4
misaochan
reviewed
Mar 18, 2022
app/src/main/res/values/strings.xml
Outdated
| <string name="feedback_sharing_data_alert">Please remove from this email any information that you are not comfortable sharing publicly. Also, please be aware that your email address with which you are posting, and the associated name and profile picture, will be visible publicly.</string> | ||
| <string name="achievements_unavailable_beta">Achievements are only available in the prod flavor.</string> | ||
| <string name="leaderboard_unavailable_beta">The leaderboard is only available in the prod flavor.</string> | ||
| <string name="achievements_unavailable_beta">Achievements are only available in the prod flavor, Please check the developer documentation.</string> |
Member
There was a problem hiding this comment.
"Please" needs to be "please", not with a capital "P".
Contributor
Author
Rishavgupta12345
left a comment
There was a problem hiding this comment.
done the changes @misaochan @4D17Y4
4D17Y4
approved these changes
Mar 20, 2022
Contributor
|
Thanks @Rishavgupta12345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [Bug]: Prod/beta flavor messages may be nonsense for users #4850