Explore nearby pictures

[neslihanturan]

Description (required)

Fixes #28

This PR is a WIP. What is done so far:

• Explores commons uploads by location
• Explores commons uploads by search query if they have location attribute
  Known issue are:
• Clicking to markers does not open media details
• Search this area button wont become visible
• Does not follow current location
• Marker icons are not thumbnails yet

What changes did you make and why?

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

---

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

[misaochan]

Hi @neslihanturan , thanks for the PR! It's exciting to see the progress of this feature. :)

I tested this on my real device (noting, as you mentioned above, that some functionality is missing). A few notes:

• It took a very, very long time to display the pins the first time I loaded Nearby. Roughly 3 minutes, according to my timestamps. There were also two loading progress bars running simultaneously, overlapping each other.
• "Search this area" actually works perfectly for me! :) Great job with fixing that.
• Some of the UI elements seem a bit out of place. Referring to the screenshot below, the "center map on user" button and scale indicator is in the wrong spot, and the Mapbox links are displaying raw HTML.

I completely understand that this is WIP. The code looks good to me, otherwise. Looking forward to being able to merge!

[misaochan]

@neslihanturan Tested this again and it looks amazing now!! Nice work! 🚀

The load times, search this area, tapping individual images, links etc all work perfectly for me.

Just a couple of minor issues:

1. I know that in Commons all the images have "File:" and ".jpg" (or other file type) prefixes and suffixes to them, but I don't think that this is needed in a user-facing image browsing app. So for instance, in the screenshot below I think the image title should just be "Sunset in Beachmere at low-tide Moreton Marine Park". This should apply in both the expanded and non-expanded views.
2. Similarly, I think "Media Details" should be shortened to just "Details", which also makes it tidier on most screen sizes.

Again, great job and looking forward to releasing this soon! :)

[codecov]

Codecov Report

Merging #4910 (d3fdf05) into master (7655562) will decrease coverage by 2.28%.
The diff coverage is 5.06%.

@@             Coverage Diff              @@
##             master    #4910      +/-   ##
============================================
- Coverage     52.23%   49.95%   -2.29%     
- Complexity     2377     2382       +5     
============================================
  Files           344      352       +8     
  Lines         16268    17050     +782     
  Branches       1429     1518      +89     
============================================
+ Hits           8498     8517      +19     
- Misses         7133     7894     +761     
- Partials        637      639       +2     

Impacted Files	Coverage Δ
...mons/bookmarks/locations/BookmarkLocationsDao.java	80.00% <0.00%> (-1.67%)	⬇️
...r/free/nrw/commons/contributions/MainActivity.java	74.45% <0.00%> (-0.41%)	⬇️
...va/fr/free/nrw/commons/explore/SearchActivity.java	86.36% <ø> (ø)
.../free/nrw/commons/explore/map/ExploreMapCalls.java	0.00% <0.00%> (ø)
...ee/nrw/commons/explore/map/ExploreMapContract.java	0.00% <0.00%> (ø)
.../nrw/commons/explore/map/ExploreMapController.java	0.00% <0.00%> (ø)
...e/nrw/commons/explore/map/ExploreMapPresenter.java	0.00% <0.00%> (ø)
...a/fr/free/nrw/commons/nearby/NearbyController.java	92.30% <ø> (-0.08%)	⬇️
...rc/main/java/fr/free/nrw/commons/nearby/Place.java	22.41% <0.00%> (-6.48%)	⬇️
...commons/nearby/fragments/NearbyParentFragment.java	15.38% <0.00%> (+0.01%)	⬆️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7655562...d3fdf05. Read the comment docs.

[misaochan]

Works perfectly, merging. Looking forward to this feature, thank you for your hard work @neslihanturan ! :)