Fixes 4913 : Depiction not found despite Wikidata item with that exact name#4933
Merged
nicolas-raoul merged 1 commit intocommons-app:masterfrom Apr 14, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4933 +/- ##
============================================
- Coverage 52.23% 52.22% -0.02%
- Complexity 2377 2380 +3
============================================
Files 344 344
Lines 16268 16275 +7
Branches 1429 1429
============================================
+ Hits 8498 8500 +2
- Misses 7133 7139 +6
+ Partials 637 636 -1
Continue to review full report at Codecov.
|
nicolas-raoul
approved these changes
Apr 14, 2022
Member
nicolas-raoul
left a comment
There was a problem hiding this comment.
It fixes all examples I gave in the issue, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4913
What changes did you make and why?
Handled entities that neither have description nor P31 property to prevent returning an empty list
Tests performed (required)
Tested latest ProdDebug on Pixel 3 with API level 30