Skip to content

Fixes 4913 : Depiction not found despite Wikidata item with that exact name#4933

Merged
nicolas-raoul merged 1 commit intocommons-app:masterfrom
Ayan-10:4913_depiction_not_found
Apr 14, 2022
Merged

Fixes 4913 : Depiction not found despite Wikidata item with that exact name#4933
nicolas-raoul merged 1 commit intocommons-app:masterfrom
Ayan-10:4913_depiction_not_found

Conversation

@Ayan-10
Copy link
Contributor

@Ayan-10 Ayan-10 commented Apr 12, 2022

Description (required)

Fixes #4913

What changes did you make and why?

Handled entities that neither have description nor P31 property to prevent returning an empty list

Tests performed (required)

Tested latest ProdDebug on Pixel 3 with API level 30

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #4933 (b479d9c) into master (7655562) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4933      +/-   ##
============================================
- Coverage     52.23%   52.22%   -0.02%     
- Complexity     2377     2380       +3     
============================================
  Files           344      344              
  Lines         16268    16275       +7     
  Branches       1429     1429              
============================================
+ Hits           8498     8500       +2     
- Misses         7133     7139       +6     
+ Partials        637      636       -1     
Impacted Files Coverage Δ
...ee/nrw/commons/explore/depictions/DepictsClient.kt 97.50% <100.00%> (+6.59%) ⬆️
.../nrw/commons/category/CategoryContentProvider.java 12.50% <0.00%> (-14.29%) ⬇️
...w/commons/upload/categories/BaseDelegateAdapter.kt 35.29% <0.00%> (-11.77%) ⬇️
...va/fr/free/nrw/commons/category/CategoriesModel.kt 75.00% <0.00%> (-1.09%) ⬇️
...ns/upload/categories/UploadCategoriesFragment.java 57.53% <0.00%> (-0.69%) ⬇️
.../fr/free/nrw/commons/widget/PicOfDayAppWidget.java 66.00% <0.00%> (+2.00%) ⬆️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 60.13% <0.00%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7655562...b479d9c. Read the comment docs.

@misaochan misaochan requested a review from nicolas-raoul April 14, 2022 09:29
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes all examples I gave in the issue, thanks!

@nicolas-raoul nicolas-raoul merged commit 17ac591 into commons-app:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Depiction not found despite Wikidata item with that exact name

2 participants