4664: Moved WelcomeActivity to ViewBinding #5063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @psh ,
I made the changes as it says in these lines, but I kept getting error. I tried to run other test classes , like AccountUtilUnitTest.kt and it have failes due to same problem -
Refer to the error image below please. I can see one of your PR #4702 have been merged without any test class file changes. |
|
@dbrant Requesting to review this PR |
|
Hi @psh Can you review this PR? |
nicolas-raoul
approved these changes
Oct 29, 2022
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
* 4664: Moved WelcomeActivity to ViewBinding * 4664: Removed non-null test on member variables
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
* 4664: Moved WelcomeActivity to ViewBinding * 4664: Removed non-null test on member variables
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
* 4664: Moved WelcomeActivity to ViewBinding * 4664: Removed non-null test on member variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4664
What changes did you make and why?
WelcomeActivity.javais currently using Butterknife to to inject views into Android components.butterknifewithviewbinding, which is always null safe, type-safe and supports both Java and Kotlin.