4664: Moved ImageFragment to ViewBinding #5067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbrant Requesting to review this PR |
nicolas-raoul
approved these changes
Oct 29, 2022
|
Thanks @bosankus and sorry for the long wait! |
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4664
What changes did you make and why?
ImageFragment.ktis currently using Kotlin Synthetic which creates auto-generated class, and has been alread deprecated.kotlin-syntheticwithviewbinding, which is always null safe, type-safe and supports both Java and Kotlin.NB: During migration a redundant semicolon was removed.