Skip to content

Fix [Bug]: Order of images does not persist #4964 #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix [Bug]: Order of images does not persist #4964 #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@ protected void onBecameVisible() {

@Override
public void goToNextScreen() {
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this));
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this)+1);
}

@Override
public void goToPreviousScreen() {
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this));
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this)-1);
}

@Override
Expand Down Expand Up @@ -319,7 +319,7 @@ public void onPreviousButtonClicked() {
updateDepicts();
goBackToPreviousScreen();
} else {
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this));
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this)-1);
}
}

Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/fr/free/nrw/commons/upload/license/MediaLicenseFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,12 @@ public void onDestroy() {

@OnClick(R.id.btn_previous)
public void onPreviousButtonClicked() {
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this));
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this)-1);
}

@OnClick(R.id.btn_submit)
public void onSubmitButtonClicked() {
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this));
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this)+1);
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,12 @@ private void showInfoAlert(int titleStringID, int messageStringId) {

@OnClick(R.id.btn_next)
public void onNextButtonClicked() {
presenter.verifyImageQuality(callback.getIndexInViewFlipper(this));
presenter.verifyImageQuality(callback.getIndexInViewFlipper(this)+1);
}

@OnClick(R.id.btn_previous)
public void onPreviousButtonClicked() {
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this));
callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this)-1);
}

@OnClick(R.id.btn_add_description)
Expand Down Expand Up @@ -320,7 +320,7 @@ public void showProgress(boolean shouldShow) {

@Override
public void onImageValidationSuccess() {
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this));
callback.onNextButtonClicked(callback.getIndexInViewFlipper(this)+1);
}

/**
Expand Down