[Enhancement] Fix #5042 Add copy link button #5080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 18, 2022 18:40
…sh and Simplified Chinese text in strings.xml.
junjiemu62
approved these changes
Oct 29, 2022
|
Thanks for working on this! I tested it with Contributions and Explore and the new function worked well. One thing I noticed is that the one additional button might not be ideal with a narrow screen. "Contributions" was not fully displayed when I tested with a 1080x1920 420 dpi emulator. Could the new button be hidden in the dot menu in a narrow screen, perhaps? (There might be other solutions, but it was the first one I thought about.) |
whym
reviewed
Dec 31, 2022
|
@nicolas-raoul This pr should be good to go after the changes in the strings? |
|
@Justweng Are you still working on this? |
nicolas-raoul
approved these changes
Dec 14, 2024
This can be the topic of another issue. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5042
Add a copy link button next to the share link button.
Tests performed
Tested MediaDetailPagerFragment on Pixel 4 with API level 28.
Screenshots
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.