4664: Moved PageableMediaFragment to ViewBinding #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nicolas-raoul merged 1 commit into commons-app:master from bosankus:moved-pageable-media-fragment-to-viewbinding

Oct 29, 2022

Contributor

bosankus commented Oct 23, 2022

Fixes #4664

What changes did you make and why?

Issue: As per the information provided and work request on the ticket above, PageableMediaFragment .kt is currently using Kotlin Synthetic which creates auto-generated class, and has been alread deprecated.
Solution: Hence migration was done by replacing kotlin-synthetic with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.


          4664: Moved PageableMediaFragment to ViewBinding

f41689a

Contributor Author

bosankus commented Oct 29, 2022

Hi @nicolas-raoul Can you approve this too ?

nicolas-raoul approved these changes

View reviewed changes

nicolas-raoul merged commit 3fd63b0 into commons-app:master

bosankus deleted the moved-pageable-media-fragment-to-viewbinding branch

October 29, 2022 17:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet