4664: Moved AdvanceQueryFragment to ViewBinding

[bosankus]

Fixes #4664

What changes did you make and why?

• Issue: As per the information provided and work request on the ticket above, AdvanceQueryFragment.kt is currently using findViewById which is tedious and not needed, and can cause runtime crashes.
• Solution: Hence migration was done by replacing findViewById with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.

[bosankus]

Hi @nicolas-raoul Can you approve this too ?

[nicolas-raoul]

Oops that seems to make unit tests fail, would you mind fixing the unit test?

fr.free.nrw.commons.nearby.AdvanceQueryFragmentUnitTests > testOnViewCreated FAILED
    java.lang.Exception at AndroidTestEnvironment.java:538
        Caused by: java.lang.NullPointerException at AdvanceQueryFragmentUnitTests.kt:110

[nicolas-raoul]

@bosankus Did you get a chance to check the unit tests, maybe?

[bosankus]

@nicolas-raoul have not. let me check on this. And update here.

[nicolas-raoul]

Great, thanks a lot! :-)