Skip to content

Fix issue #2649, create unit tests for darkness-checking logic using six images #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2022
Merged

Fix issue #2649, create unit tests for darkness-checking logic using six images #5096

merged 3 commits into from
Oct 29, 2022

Conversation

gengarrrr
Copy link
Contributor

Description (required)

Fixes #2649

Create unit tests for darkness-checking logic, using four proper images and two dark images to check if checkIfImageIsTooDark

method works properly.

Tests performed (required)

Tested Build variant: BetaDebug on Pixel 2 with API level 30.

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@nicolas-raoul nicolas-raoul merged commit 09564c3 into commons-app:master Oct 29, 2022
@nicolas-raoul
Copy link
Member

Thanks for the unit tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junjiemu62 junjiemu62 junjiemu62 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unit tests for darkness-checking logic
4 participants
@gengarrrr @nicolas-raoul @junjiemu62 @RuofanYang1