Fix #4347: Remove leading and trailing spaces in title #5141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Feb 8, 2023
app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java
Show resolved
Hide resolved
nicolas-raoul
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Tested by uploading https://commons.wikimedia.org/wiki/File:Potato_cream_covered_curry_udon_in_Ebisu-Minami.jpg fine spaces at the beginning and end of captions and descriptions, in 3 languages including Japanese. Correctly removes all spaces from all captions and from filename.
|
Thanks @chan-j-d, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4347
What changes did you make and why?
I updated the
removeTrailingWhitespacemethod to remove both leading and trailing whitespaces. I realized that the issue was partially solved by #5085 and I just had to update the method to also remove leading whitespaces.The
trimmethod that Java implements only removes chars with codepoint <= 'U+0020' which makes it less general than what is currently desired. The ideal inbuilt method would bestripwhich is not supported at the current version of SDK so a manual implementation was done similar to what was there before.Relevant test cases were also updated to include the new requirements.
Tests performed (required)
Tested Build variant: BetaDebug on Pixel XL with API level 30.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.