-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixes #4964: ordered images by timestamp #5189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes #4964: ordered images by timestamp #5189
Conversation
I think someone else is assigned to this mentioned issue. Is it @nicolas-raoul ? |
@JesusMurguia Can you please ask at #4964 to be assigned? With GitHub I can technically not assign you unless you comment on the issue. Thanks! |
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried and strangely the pictures are presented in the opposite of the historical order: Last to first. Was it working in your tests? Maybe the order gets mixed up later? Or maybe just inverse the order? Or maybe file timestamp are not reliable and we should instead rely on EXIF dates?
By the way thanks for switching to Timber, that's perfect! |
Yeah, I just left the order in the opposite way because I was testing both directions. I changed it to the right order now, my bad! |
The changes only affect the images coming from external sources like the share button on the gallery, because these images don't respect the selection order, when using the normal and custom picker from inside the app, the images are sorted by selection order, I did it this way because the issue was referring specifically to this uploading method. |
Fixes #4964
Ordered the images by timestamp when they come from external sources (share button)