commons-app · nicolas-raoul · Apr 3, 2023 · Mar 30, 2023 · Mar 30, 2023 · Mar 31, 2023
diff --git a/app/build.gradle b/app/build.gradle
@@ -38,10 +38,10 @@ dependencies {
     implementation 'fr.avianey.com.viewpagerindicator:library:2.4.1.1@aar'
     implementation 'com.github.chrisbanes:PhotoView:2.0.0'
     implementation 'com.github.pedrovgs:renderers:3.3.3'
-    implementation 'com.mapbox.mapboxsdk:mapbox-android-sdk:9.2.1'
-    implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-localization-v9:0.12.0'
-    implementation 'com.mapbox.mapboxsdk:mapbox-android-plugin-scalebar-v9:0.5.0'
-    implementation 'com.mapbox.mapboxsdk:mapbox-android-telemetry:7.0.0'
+    implementation "org.maplibre.gl:android-sdk:$MAPLIBRE_VERSION"
+    implementation 'org.maplibre.gl:android-plugin-scalebar-v9:1.0.0'
+
+    implementation 'com.jakewharton.timber:timber:4.7.1'
     implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0'
     implementation 'com.dinuscxj:circleprogressbar:1.1.1'
     implementation 'com.karumi:dexter:5.0.0'
@@ -246,6 +246,8 @@ android {
 
     configurations.all {
         resolutionStrategy.force 'androidx.annotation:annotation:1.1.0'
+        resolutionStrategy.force 'com.jakewharton.timber:timber:4.7.1'
+        resolutionStrategy.force 'androidx.fragment:fragment:1.3.6'
         exclude module: 'okhttp-ws'
     }
     flavorDimensions 'tier'

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -17,6 +17,7 @@
     <uses-permission android:name="com.google.android.apps.photos.permission.GOOGLE_PHOTOS" />
     <uses-permission android:name="android.permission.SET_WALLPAPER"/>
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
+    <uses-permission android:name="android.permission.ACCESS_MEDIA_LOCATION"/>
 
     <queries>
         <!-- Browser -->

diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
@@ -24,6 +24,7 @@
 import com.facebook.imagepipeline.core.ImagePipeline;
 import com.facebook.imagepipeline.core.ImagePipelineConfig;
 import com.mapbox.mapboxsdk.Mapbox;
+import com.mapbox.mapboxsdk.WellKnownTileServer;
 import fr.free.nrw.commons.auth.SessionManager;
 import fr.free.nrw.commons.bookmarks.items.BookmarkItemsDao.Table;
 import fr.free.nrw.commons.bookmarks.locations.BookmarkLocationsDao;
@@ -53,7 +54,6 @@
 import java.util.Set;
 import javax.inject.Inject;
 import javax.inject.Named;
-import leakcanary.ObjectWatcher;
 import org.acra.ACRA;
 import org.acra.annotation.AcraCore;
 import org.acra.annotation.AcraDialog;
@@ -121,8 +121,6 @@ public class CommonsApplication extends MultiDexApplication {
      * Constants End
      */
 
-    private ObjectWatcher objectWatcher;
-
     private static CommonsApplication INSTANCE;
 
     public static CommonsApplication getInstance() {
@@ -152,7 +150,7 @@ public void onCreate() {
 
         INSTANCE = this;
         ACRA.init(this);
-        Mapbox.getInstance(this, getString(R.string.mapbox_commons_app_token));
+        Mapbox.getInstance(this, getString(R.string.mapbox_commons_app_token), WellKnownTileServer.Mapbox);
 
         ApplicationlessInjection
             .getInstance(this)
@@ -268,17 +266,6 @@ public String getUserAgent() {
             + " (https://mediawiki.org/wiki/Apps/Commons) Android/" + Build.VERSION.RELEASE;
     }
 
-    /**
-     * Provides a way to get member objectWatcher
-     *
-     * @param context Application context
-     * @return application member objectWatcher
-     */
-    public static ObjectWatcher getObjectWatcher(Context context) {
-        CommonsApplication application = (CommonsApplication) context.getApplicationContext();
-        return application.objectWatcher;
-    }
-
     /**
      * clears data of current application
      *

diff --git a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java
@@ -31,18 +31,18 @@
 import androidx.lifecycle.Observer;
 import androidx.lifecycle.ViewModelProvider;
 import com.google.android.material.floatingactionbutton.FloatingActionButton;
-import com.mapbox.android.core.location.LocationEngineCallback;
-import com.mapbox.android.core.location.LocationEngineResult;
-import com.mapbox.android.core.permissions.PermissionsManager;
 import com.mapbox.geojson.Point;
 import com.mapbox.mapboxsdk.camera.CameraPosition;
 import com.mapbox.mapboxsdk.camera.CameraPosition.Builder;
 import com.mapbox.mapboxsdk.camera.CameraUpdateFactory;
 import com.mapbox.mapboxsdk.geometry.LatLng;
 import com.mapbox.mapboxsdk.location.LocationComponent;
 import com.mapbox.mapboxsdk.location.LocationComponentActivationOptions;
+import com.mapbox.mapboxsdk.location.engine.LocationEngineCallback;
+import com.mapbox.mapboxsdk.location.engine.LocationEngineResult;
 import com.mapbox.mapboxsdk.location.modes.CameraMode;
 import com.mapbox.mapboxsdk.location.modes.RenderMode;
+import com.mapbox.mapboxsdk.location.permissions.PermissionsManager;
 import com.mapbox.mapboxsdk.maps.MapView;
 import com.mapbox.mapboxsdk.maps.MapboxMap;
 import com.mapbox.mapboxsdk.maps.MapboxMap.OnCameraIdleListener;
@@ -57,6 +57,7 @@
 import fr.free.nrw.commons.Utils;
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.theme.BaseActivity;
+import fr.free.nrw.commons.utils.SystemThemeUtils;
 import javax.inject.Inject;
 import javax.inject.Named;
 import org.jetbrains.annotations.NotNull;
@@ -139,11 +140,20 @@ public class LocationPickerActivity extends BaseActivity implements OnMapReadyCa
     @Named("default_preferences")
     public
     JsonKvStore applicationKvStore;
+    /**
+     * isDarkTheme: for keeping a track of the device theme and modifying the map theme accordingly
+     */
+    @Inject
+    SystemThemeUtils systemThemeUtils;
+    private boolean isDarkTheme;
 
     @Override
     protected void onCreate(@Nullable final Bundle savedInstanceState) {
+        getWindow().requestFeature(Window.FEATURE_ACTION_BAR);
         super.onCreate(savedInstanceState);
 
+        isDarkTheme = systemThemeUtils.isDeviceInNightMode();
+
         getWindow().requestFeature(Window.FEATURE_ACTION_BAR);
         final ActionBar actionBar = getSupportActionBar();
         if (actionBar != null) {
@@ -194,7 +204,7 @@ private void addCredits() {
      * Clicking back button destroy locationPickerActivity
      */
     private void addBackButtonListener() {
-        final ImageView backButton = findViewById(R.id.mapbox_place_picker_toolbar_back_button);
+        final ImageView backButton = findViewById(R.id.maplibre_place_picker_toolbar_back_button);
         backButton.setOnClickListener(view -> finish());
     }
 
@@ -238,7 +248,8 @@ private void getToolbarUI() {
     @Override
     public void onMapReady(final MapboxMap mapboxMap) {
         this.mapboxMap = mapboxMap;
-        mapboxMap.setStyle(Style.MAPBOX_STREETS, this::onStyleLoaded);
+        mapboxMap.setStyle(isDarkTheme ? LocationPickerConstants.DARK_MAP_STYLE :
+            LocationPickerConstants.STREETS_MAP_STYLE, this::onStyleLoaded);
     }
 
     /**

diff --git a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerConstants.java b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerConstants.java
@@ -1,5 +1,7 @@
 package fr.free.nrw.commons.LocationPicker;
 
+import com.mapbox.mapboxsdk.maps.Style;
+
 /**
  * Constants need for location picking
  */
@@ -11,6 +13,12 @@ public final class LocationPickerConstants {
     public static final String MAP_CAMERA_POSITION
         = "location.picker.cameraPosition";
 
+    public static final String DARK_MAP_STYLE
+        = Style.getPredefinedStyle("Dark");
+
+    public static final String STREETS_MAP_STYLE
+        = Style.getPredefinedStyle("Streets");
+
 
     private LocationPickerConstants() {
     }

diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
@@ -3,9 +3,12 @@
 import static fr.free.nrw.commons.wikidata.WikidataConstants.PLACE_OBJECT;
 
 import android.Manifest;
+import android.Manifest.permission;
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
+import android.os.Build.VERSION;
+import android.os.Build.VERSION_CODES;
 import androidx.annotation.NonNull;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.filepicker.DefaultCallback;
@@ -66,7 +69,18 @@ public void initiateCustomGalleryPickWithPermission(final Activity activity) {
 
         PermissionUtils.checkPermissionsAndPerformAction(activity,
             Manifest.permission.WRITE_EXTERNAL_STORAGE,
-            () -> FilePicker.openCustomSelector(activity, 0),
+            () -> {
+                if (VERSION.SDK_INT >= VERSION_CODES.Q) {
+                    PermissionUtils.checkPermissionsAndPerformAction(
+                        activity,
+                        permission.ACCESS_MEDIA_LOCATION,
+                        () -> {},
+                        R.string.media_location_permission_denied,
+                        R.string.add_location_manually
+                    );
+                }
+                FilePicker.openCustomSelector(activity, 0);
+            },
             R.string.storage_permission_title,
             R.string.write_storage_permission_rationale);
     }

diff --git a/...ain/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorViewModelFactory.kt b/...ain/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorViewModelFactory.kt
@@ -10,7 +10,7 @@ import javax.inject.Inject
  */
 class CustomSelectorViewModelFactory @Inject constructor(val context: Context,val imageFileLoader: ImageFileLoader) : ViewModelProvider.Factory {
 
-    override fun<CustomSelectorViewModel: ViewModel?> create(modelClass: Class<CustomSelectorViewModel>) : CustomSelectorViewModel {
+    override fun<CustomSelectorViewModel: ViewModel> create(modelClass: Class<CustomSelectorViewModel>) : CustomSelectorViewModel {
         return CustomSelectorViewModel(context,imageFileLoader) as CustomSelectorViewModel
     }
 

diff --git a/app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapFragment.java
@@ -81,6 +81,7 @@
 import io.reactivex.Observable;
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.schedulers.Schedulers;
+import java.util.Arrays;
 import java.util.List;
 import javax.inject.Inject;
 import javax.inject.Named;
@@ -189,7 +190,8 @@ public void onViewCreated(@NonNull final View view, @Nullable final Bundle saved
             mapBox = mapBoxMap;
             initViews();
             presenter.setActionListeners(applicationKvStore);
-            mapBoxMap.setStyle(isDarkTheme? Style.DARK:Style.OUTDOORS, style -> {
+            mapBoxMap.setStyle(isDarkTheme? Style.getPredefinedStyle("Dark"):
+                Style.getPredefinedStyle("Outdoors"), style -> {
                 final UiSettings uiSettings = mapBoxMap.getUiSettings();
                 uiSettings.setCompassGravity(Gravity.BOTTOM | Gravity.LEFT);
                 uiSettings.setCompassMargins(12, 0, 0, 24);

diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
@@ -316,7 +316,7 @@ public void onViewCreated(@NonNull final View view, @Nullable final Bundle saved
             initViews();
             presenter.setActionListeners(applicationKvStore);
             initNearbyFilter();
-            mapBoxMap.setStyle(isDarkTheme?Style.DARK:Style.OUTDOORS, style -> {
+            mapBoxMap.setStyle(isDarkTheme?Style.getPredefinedStyle("Dark"):Style.getPredefinedStyle("Outdoors"), style -> {
                 final UiSettings uiSettings = mapBoxMap.getUiSettings();
                 uiSettings.setCompassGravity(Gravity.BOTTOM | Gravity.LEFT);
                 uiSettings.setCompassMargins(12, 0, 0, 24);

diff --git a/app/src/main/java/fr/free/nrw/commons/settings/Prefs.java b/app/src/main/java/fr/free/nrw/commons/settings/Prefs.java
@@ -10,7 +10,6 @@ public class Prefs {
     public static final String DESCRIPTION_LANGUAGE = "languageDescription";
     public static final String APP_UI_LANGUAGE = "appUiLanguage";
     public static final String KEY_THEME_VALUE = "appThemePref";
-    public static final String TELEMETRY_PREFERENCE = "telemetryPref";
 
     public static class Licenses {
         public static final String CC_BY_SA_3 = "CC BY-SA 3.0";

diff --git a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java
@@ -31,7 +31,6 @@
 import com.karumi.dexter.listener.PermissionGrantedResponse;
 import com.karumi.dexter.listener.single.BasePermissionListener;
 import com.mapbox.mapboxsdk.Mapbox;
-import com.mapbox.mapboxsdk.maps.TelemetryDefinition;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.Utils;
 import fr.free.nrw.commons.campaigns.CampaignView;
@@ -161,21 +160,6 @@ public boolean onPreferenceClick(Preference preference) {
             findPreference(CampaignView.CAMPAIGNS_DEFAULT_PREFERENCE).setEnabled(false);
             findPreference("managed_exif_tags").setEnabled(false);
         }
-
-        // Opting out of telemetry due to app's privacy policy
-        telemetryOptInOut(false);
-        defaultKvStore.putBoolean(Prefs.TELEMETRY_PREFERENCE,false);
-    }
-
-    /**
-     * Opt in or out of MapBox telemetry
-     * @param shouldOptIn
-     */
-    private void telemetryOptInOut(boolean shouldOptIn){
-        TelemetryDefinition telemetry = Mapbox.getTelemetry();
-        if (telemetry != null) {
-            telemetry.setUserTelemetryRequestState(shouldOptIn);
-        }
     }
 
     @Override

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java
@@ -174,15 +174,15 @@ public void bind(int position) {
             if (position == 0) {
                 removeButton.setVisibility(View.GONE);
                 captionInputLayout.setEndIconMode(TextInputLayout.END_ICON_CUSTOM);
-                captionInputLayout.setEndIconDrawable(R.drawable.mapbox_info_icon_default);
+                captionInputLayout.setEndIconDrawable(R.drawable.maplibre_info_icon_default);
                 captionInputLayout.setEndIconOnClickListener(v ->
                     callback.showAlert(R.string.media_detail_caption, R.string.caption_info));
                 Objects.requireNonNull(captionInputLayout.getEditText()).setFilters(new InputFilter[] {
                     new UploadMediaDetailInputFilter()
                 });
 
                 descInputLayout.setEndIconMode(TextInputLayout.END_ICON_CUSTOM);
-                descInputLayout.setEndIconDrawable(R.drawable.mapbox_info_icon_default);
+                descInputLayout.setEndIconDrawable(R.drawable.maplibre_info_icon_default);
                 descInputLayout.setEndIconOnClickListener(v ->
                     callback.showAlert(R.string.media_detail_description, R.string.description_info));
 

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
@@ -11,7 +11,7 @@ import androidx.core.app.NotificationManagerCompat
 import androidx.work.CoroutineWorker
 import androidx.work.Data
 import androidx.work.WorkerParameters
-import com.mapbox.mapboxsdk.plugins.localization.BuildConfig
+import androidx.multidex.BuildConfig
 import dagger.android.ContributesAndroidInjector
 import fr.free.nrw.commons.CommonsApplication
 import fr.free.nrw.commons.Media

diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml
@@ -4,6 +4,7 @@
     android:id="@+id/drawer_layout"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
+    android:background="?attr/mainBackground"
     android:orientation="vertical">
     <LinearLayout
         android:id="@+id/toolbarLayout"

diff --git a/app/src/main/res/layout/activity_notification.xml b/app/src/main/res/layout/activity_notification.xml
@@ -4,7 +4,8 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/drawer_layout"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:background="?attr/mainBackground">
 
     <RelativeLayout
         android:layout_width="match_parent"

diff --git a/app/src/main/res/layout/activity_review.xml b/app/src/main/res/layout/activity_review.xml
@@ -4,7 +4,8 @@
   xmlns:tools="http://schemas.android.com/tools"
   android:id="@+id/drawer_layout"
   android:layout_width="match_parent"
-  android:layout_height="match_parent">
+  android:layout_height="match_parent"
+  android:background="?attr/mainBackground">
 
   <FrameLayout
     android:id="@+id/mediaDetailContainer"

diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml
@@ -5,6 +5,7 @@
     android:id="@+id/drawer_layout"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
+    android:background="?attr/mainBackground"
     android:orientation="vertical">
     <LinearLayout
         android:id="@+id/toolbarLayout"

diff --git a/app/src/main/res/layout/content_location_picker.xml b/app/src/main/res/layout/content_location_picker.xml
@@ -36,7 +36,7 @@
     android:id="@+id/map_view"
     android:layout_width="0dp"
     android:layout_height="0dp"
-    app:mapbox_uiLogo="false"
+    app:maplibre_uiLogo="false"
     app:layout_constraintBottom_toBottomOf="parent"
     app:layout_constraintEnd_toEndOf="parent"
     app:layout_constraintStart_toStartOf="parent"

diff --git a/app/src/main/res/layout/custom_selector_toolbar.xml b/app/src/main/res/layout/custom_selector_toolbar.xml
@@ -6,7 +6,8 @@
       android:id="@+id/toolbar_layout"
       android:layout_width="match_parent"
       android:layout_height="?attr/actionBarSize"
-      app:layout_constraintTop_toTopOf="parent">
+      app:layout_constraintTop_toTopOf="parent"
+      android:background="?attr/mainBackground">
 
       <ImageButton
         android:id="@+id/back"

diff --git a/app/src/main/res/layout/dialog_feedback.xml b/app/src/main/res/layout/dialog_feedback.xml
@@ -15,7 +15,7 @@
       android:layout_margin="@dimen/dimen_6"
       android:padding="@dimen/tiny_gap"
       android:textSize="24sp"
-      android:textColor="@color/black"
+      android:textColor="?android:attr/textColorPrimary"
       android:text="@string/navigation_item_feedback"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content" />
@@ -44,7 +44,7 @@
       android:layout_margin="@dimen/dimen_6"
       android:padding="4dp"
       android:textSize="21sp"
-      android:textColor="@color/black"
+      android:textColor="?android:attr/textColorPrimary"
       android:text="@string/select_feedback_data_choice"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content" />

diff --git a/app/src/main/res/layout/fragment_achievements.xml b/app/src/main/res/layout/fragment_achievements.xml
@@ -4,7 +4,8 @@
   xmlns:tools="http://schemas.android.com/tools"
   android:id="@+id/drawer_layout"
   android:layout_width="match_parent"
-  android:layout_height="match_parent">
+  android:layout_height="match_parent"
+  android:background="?attr/achievementBackground">
 
     <ScrollView
       android:layout_width="wrap_content"