Skip to content

[WIP] Fix 5263: Custom picker displays pictures in non-historical order #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Fix 5263: Custom picker displays pictures in non-historical order #5265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix pictures order, more work needed
  • Loading branch information
@nicolas-raoul
nicolas-raoul committed Aug 6, 2023
commit 94b4d5b50460f097b5f90bc204a068ee1a20e779
6 changes: 5 additions & 1 deletion app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,11 @@ class ImageFragment: CommonsDaggerSupportFragment(), RefreshUIListener, PassData
*/
private fun handleResult(result:Result){
if(result.status is CallbackStatus.SUCCESS){
val images = result.images
// Sort images by name, rather than the default ID number which is almost random (see issue #5263).
var images = ArrayList<Image>(
result.images.sortedWith(compareBy({ it.name }))
)

if(images.isNotEmpty()) {
filteredImages = ImageHelper.filterImages(images, bucketId)
allImages = ArrayList(filteredImages)
Expand Down