Android 13 permission related fixes #5299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Sep 21, 2023
|
|
||
|
|
||
| public class PermissionUtils { | ||
|
|
||
| public static String[] PERMISSIONS_STORAGE = isSDKVersionScopedStorageCompatible() ? | ||
| isSDKVersionTiramisu() ? new String[]{Manifest.permission.READ_MEDIA_AUDIO, |
There was a problem hiding this comment.
I removed the AUDIO and VIDEO lines here and in the manifest, it works just as well, with all 3 upload methods. :-)
Would you mind removing these from the pull request? Or I can do it after merging this pull request, if you don't have time.
There was a problem hiding this comment.
Done, please pull the latest changes in this PR
nicolas-raoul
approved these changes
Sep 22, 2023
This was referenced Sep 22, 2023
|
Hi @srishti-R, thank for this fix. I tested latest version from main branch and now I can finally upload pictures from the app with my Android 13 phone. ❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5297
What changes did you make and why?
Updated manifest permissions and runtime storage permissions
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Tested this branch on API 33(android13)
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.