Skip to content

Fixes dark mode color contrast fix #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

srishti-R
Copy link
Contributor

Description (required)

Fixes #5301

What changes did you make and why?
Light blue color in place of dark blue when device is in dark mode.
Changes dark mode appearance. Light mode remains unaffected.

Tests performed (required)

Tested {prodDebug} on {pixel 5 emulator} with API level {34}.

Screenshots (for UI changes only)
light
light2
ligh3
light4

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
If anyone with UI knowledge has a different opinion, they are welcome to send a further pull request. :-)

@nicolas-raoul nicolas-raoul merged commit ff7fa79 into commons-app:main Sep 24, 2023
@sivaraam
Copy link
Member

Hey @srishti-R 👋🏼
Thanks for your PR! I could confirm that this fixes the contrast when the device them itself is dark. There's another case where I'm still seeing the old blue-on-black colour scheme. When the device theme is "Light" but the app theme is "Dark", the old blue-on-black text is shown. Here's screenshot showing both cases:

Device theme is "Dark"; App theme is "System" Device theme is "Light"; App theme is "Dark"
Screenshot_2023-09-24-20-18-48-09_d5db3f3edc380047609fe9c266f7c566 Screenshot_2023-09-24-20-17-09-71_d5db3f3edc380047609fe9c266f7c566
Screenshot_2023-09-24-20-18-52-64_d5db3f3edc380047609fe9c266f7c566 Screenshot_2023-09-24-20-17-34-11_d5db3f3edc380047609fe9c266f7c566

Would you be able to look into this ?

@srishti-R
Copy link
Contributor Author

srishti-R commented Sep 24, 2023

Hey @srishti-R 👋🏼 Thanks for your PR! I could confirm that this fixes the contrast when the device them itself is dark. There's another case where I'm still seeing the old blue-on-black colour scheme. When the device theme is "Light" but the app theme is "Dark", the old blue-on-black text is shown. Here's screenshot showing both cases:

Device theme is "Dark"; App theme is "System" Device theme is "Light"; App theme is "Dark"
Would you be able to look into this ?

Hi @sivaraam , I was not aware that there is an app level setting to change to dark theme, sure will take a look tommorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve blue-on-grey contrast in dark mode
3 participants