Skip to content

fixes copy paste option not appearing for multi asset upload #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

srishti-R
Copy link
Contributor

Description (required)

Fixes #5312

What changes did you make and why?
Added fix for copy paste option not appearing when uploading multiple images.

Tests performed (required)

Tested {prodDebug} on {Pixel 5 emulator} with API level {34}.

Screenshots (for UI changes only)
copy

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, good job identifying the root cause and circumventing that Android bug.
Thanks also for the very useful javadoc!

@nicolas-raoul nicolas-raoul merged commit f7e6d30 into commons-app:main Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes can't copy caption (Android copy/paste by long-pressing)
2 participants