Keeping track of and restart interrupted uploads #5371
Closed
Tup0lev wants to merge 2 commits intocommons-app:mainfrom
Closed
Keeping track of and restart interrupted uploads #5371Tup0lev wants to merge 2 commits intocommons-app:mainfrom
Tup0lev wants to merge 2 commits intocommons-app:mainfrom
Conversation
nicolas-raoul
requested changes
Oct 30, 2023
| alertDialogBuilder.setPositiveButton("OK", new DialogInterface.OnClickListener() { | ||
| @Override | ||
| public void onClick(DialogInterface dialogInterface, int i) { | ||
| //TODO: restart the upload |
Member
There was a problem hiding this comment.
This would be an important part I guess. 🙂
| /** | ||
| * In-memory list of contributions whose uploads have not been properly fnished | ||
| */ | ||
| public static Map<String, Boolean> unfinishedUploads = new HashMap<>(); |
Member
There was a problem hiding this comment.
Better avoid public members, especially for modifyable data structures. Better make it private and add public methods to modify the data in intended ways.
| /** | ||
| * Notifies the user about unfinished uploads. | ||
| */ | ||
| private void notifyUser() { |
Member
There was a problem hiding this comment.
Ideally retry would happen automatically, with no user action.
Member
|
@Tup0lev Thanks for your contribution. 🙂 Just pinging to know if you could look into comments given by Nicolas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Add the ability to keep track of and reupload interrupted uploads
Fixes #5282
What changes did you make and why?
Added a Java class to record unfinished uploads on disk, to keep track of the uploads across app closure/device restarts.
Tests performed (required)
Tested {Beta} on {Pixel 7 Pro} with API level {33}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.