Replaced Butterknife with Viewbinding in MoreBottomSheetFragment.java #5379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code quality warnings
psh
commented
Nov 9, 2023
| uploadFeedback(feedback); | ||
| } | ||
| }).show(); | ||
| new FeedbackDialog(getContext(), this::uploadFeedback).show(); |
There was a problem hiding this comment.
Replace anonymous inner class with method reference, suggested by the IDE
psh
commented
Nov 9, 2023
| final Intent intent = new Intent(getActivity(), AboutActivity.class); | ||
| intent.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_SINGLE_TOP); | ||
| getActivity().startActivity(intent); | ||
| requireActivity().startActivity(intent); |
There was a problem hiding this comment.
Several different instances - the call to requireActivity() replaces getActivity() to add an implicit (Android supplied) null check.
nicolas-raoul
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Butterknife with viewbinding, and dealt the a whole bunch of code quality warnings in
MoreBottomSheetFragment.javaSince the
morePeerReviewwasnt used, I removed that from the test for clarity.