Resolved issue #4513 vertical scrollbar not visible #5420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NearbyParentFragment : added referer In file NearbyParentFragment.java, I added header property, i.e., the referer - http://maps.wikimedia.org/ and set tile source to wikimedia. * Reworded comments --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
…allow downloading of build tools during CI. (commons-app#5434) * NearbyParentFragment : added referer In file NearbyParentFragment.java, I added header property, i.e., the referer - http://maps.wikimedia.org/ and set tile source to wikimedia. * Reworded comments * sdkmanager: added installation command for build-tools-30.0.3 * Revert "sdkmanager: added installation command for build-tools-30.0.3" This reverts commit b3e5019. * Update android.yml * Update gradle.properties * android.yml: removed extra debug commands Removed some debug commands because they are no longer needed. --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
…nearest item (commons-app#5433) * Resolves issue commons-app#2239 by adding an arrow for direction * Removed unnecessary change in styles.xml * spacing * javadoc --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
* Fixed Grey empty screen at Upload wizard caption step after denying files permission * Empty commit * Fixed loop issue * Created docs for earlier commits * Fixed javadoc * Fixed spaces * Added added basic features to OSM Maps * Added search location feature * Added filter to Open Street Maps * Fixed chipGroup in Open Street Maps * Removed mapBox code * Removed mapBox's code * Reformat code * Reformatted code * Removed rotation feature to map * Removed rotation files and Fixed Marker click problem * Ignored failing tests * Added voice input feature * Fixed test cases * Changed caption and description text
nicolas-raoul
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
In many parts of the app, the vertical scrollbar was not visible without the user scrolling, making it hard to figure out if there was a scrollable list or not.
Fixes #4513
What changes did you make and why?
I added the property fadeScrollbars="false" so that the scrollbar is visible even when the user hasn't scrolled, but the items overflow the list. If the items are lesser, then the scrollbar doesn't show up. I also added background colour and width to the scroll bar since the scrollbar only shows up on some devices with these properties set. These properties were not added to all instances of RecyclerView but were added only after careful inspection of the need for one. For example, in contributions activity, the fadeScrollbars property is set to true, so that the scrollbar only shows when the user scrolls; otherwise, it dies down.
Tests performed (required)
Tested betaDebug on OnePlus Nord CE 2 Lite with API level 31.
Screenshots (for UI changes only)
Dark Mode:
If items overflow, then the scrollbar shows up-
If items are lesser, then the scrollbar is not visible-
Light Mode:
If items overflow, then the scrollbar shows up-
If items are lesser, then the scrollbar is not visible-