Fixes on Edit button, there is + sign overlayed over letter E #5388 #5464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
nicolas-raoul
requested changes
Jan 23, 2024
| @@ -557,6 +577,51 @@ public String convertIdeographicSpaceToLatinSpace(String source) { | |||
|
|
|||
| } | |||
|
|
|||
| private void updateAddButtonVisibility() { | |||
There was a problem hiding this comment.
Could you please add some Javadoc?
There was a problem hiding this comment.
Sure! and Thanks for reporting, I have added javadoc in newer commit f425ead
app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.java
Show resolved
Hide resolved
nicolas-raoul
approved these changes
Jan 23, 2024
sivaraam
added a commit
that referenced
this pull request
Jan 28, 2024
Seems like a fallout of the change done in PR #5464 This hopefully should make the instrumentation tests resume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5388
What changes did you make and why?
Tests performed (required)
Tested betaDebug on Samsung S21 FE with API level 33.
Screenshots (for UI changes only)
Upload Activityhttps://github.com/commons-app/apps-android-commons/assets/114223204/17a95ff8-0670-4fcc-b870-cef1d9163f30
Description Edit Activityhttps://github.com/commons-app/apps-android-commons/assets/114223204/55ce869e-0753-440f-b2b0-3b498df6110f