Enhancing Multi-Upload Functionality for Consistent Depiction Categorization #5700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the depiction consistency of a multi-upload by ensuring that it corresponds to a single place
nicolas-raoul
requested changes
Apr 26, 2024
| @@ -810,4 +810,6 @@ Upload your first media by tapping on the add button.</string> | |||
| <item quantity="one">%d image selected</item> | |||
| <item quantity="other">%d images selected</item> | |||
| </plurals> | |||
| <string name="multiple_files_depiction">Please remember that all images in a multi-upload should belong to the same category/depiction. If the images do not share depictions and categories, please perform several uploads.</string> | |||
| <string name="multiple_files_depiction_header">Note about multi-uploads</string> | |||
There was a problem hiding this comment.
Would you mind adding a "Do not show again" checkbox on that dialog?
Thanks a lot and sorry for the delay! :-)
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
Outdated
Show resolved
Hide resolved
|
Also, would it be possible to use singular (instead of plural) when there is only one picture (not a multi-upload)? Thanks! 🙂
|
|
Otherwise it is working great, I have been using this branch for a few days with no other issues. :-) |
nicolas-raoul
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5633
This pull request enhances the multi-upload functionality to ensure consistent categorization and depiction of media files. The following improvements have been implemented:
-AlertDialog Implementation: An AlertDialog has been added to prompt users uploading multiple media files, emphasizing the importance of assigning the same category to all pictures within the multi-upload. This serves to prevent mislabeling and ensures uniformity in depiction categories across all uploaded media.
-Unified Place Recognition: When a nearby place is detected, instead of querying if a single picture within the multi-upload refers to it, we now inquire whether the entire upload pertains to the identified location. Upon affirmative confirmation, the place attribute is updated for all pictures within the multi-upload.
-Efficient Location Handling: In scenarios where the entire multi-upload is confirmed to reference a specific location, redundant location handling for individual photos is eliminated. Subsequent photos within the same upload retain the same location attribution, optimizing efficiency without compromising accuracy.
-Modularized receiveSharedItems() Method in UploadActivity.java: The receiveSharedItems() method has been modularized to enhance code readability and maintainability.
Tests performed
Tested ProdDebug on Pixel 3 with API level 34
Screenshot