Skip to content

chore : Lint fix #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 6, 2024
Merged

chore : Lint fix #5995

merged 5 commits into from
Dec 6, 2024

Conversation

neeldoshii
Copy link
Contributor

@neeldoshii neeldoshii commented Dec 4, 2024 •
edited
Loading

Fixes

  • Using 'Log' instead of 'Timber'
  • Line is longer than allowed by code style (> 100 columns)
  • Use of getter method instead of property access syntax
  • Should be replaced with Kotlin function
  • Cascade 'if' should be replaced with 'when'

@neeldoshii
Refactor : Fixed lint issues on EditActivity
6ff21d8 
- Using 'Log' instead of 'Timber'
- Line is longer than allowed by code style (> 100 columns)
- Use of getter method instead of property access syntax
- Should be replaced with Kotlin function
- Cascade 'if' should be replaced with 'when'
@neeldoshii
Suppress Deprecation
f89fb37
neeldoshii
neeldoshii commented Dec 4, 2024
View reviewed changes
app/src/main/java/fr/free/nrw/commons/edit/EditActivity.kt Outdated
val sourceExif = imageUri.toUri().path?.let { ExifInterface(it) }
// TODO(Deprecation : 'TAG_APERTURE: String' is deprecated. Deprecated in Java)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Maintainers : should we create separate issue for this referencing deprecation for it and comment issue here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks! 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

nicolas-raoul
nicolas-raoul approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a picture I had to rotate: https://commons.wikimedia.org/wiki/File:Fancy_dresses_in_Paris.jpg
Worked well.
Thanks! :-)

@misaochan
Copy link
Member

Thanks @neeldoshii !

@misaochan misaochan merged commit 64354fb into commons-app:main Dec 6, 2024
1 check passed
@neeldoshii neeldoshii mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

@misaochan misaochan misaochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neeldoshii @misaochan @nicolas-raoul