Make dialogs modal #6015
Merged
Make dialogs modal #6015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25dd1af to
1bf0e54
Compare
Member
|
Sorry would you mind rebasing from main and solving the conflicts? Thanks! :-) |
df86131 to
e912b13
Compare
Contributor
Author
|
Done |
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
e912b13 to
2937b87
Compare
nicolas-raoul
approved these changes
Dec 11, 2024
Member
nicolas-raoul
left a comment
There was a problem hiding this comment.
Tested 3 dialogs, seems to work fine.
Thanks!
This was referenced Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5778
What changes did you make and why?