-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Convert upload to kotlin (part 1) #6024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-raoul
merged 20 commits into
commons-app:main
from
psh:psh/convert-upload-to-kotlin-I
Dec 13, 2024
Merged
Convert upload to kotlin (part 1) #6024
nicolas-raoul
merged 20 commits into
commons-app:main
from
psh:psh/convert-upload-to-kotlin-I
Dec 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3480e05
to
86227f7
Compare
nicolas-raoul
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a 3-pictures upload, works fine. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #5928
Part 1 of: #6014
This PR focusses on dependency injection and contracts, with a few of the easier upload package classes. Other PR's will follow addressing fragment UIs and the rest of the main upload package.