Skip to content

FolderDeletionHelper: Fix unintentional deletion of subfolders and non-images by custom selector #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

savsch
Copy link
Contributor

@savsch savsch commented Dec 13, 2024

Description (required)

Fixes #6020

Context and cause of the issue: #6020 (comment)

Tests performed (required)

Tested BetaDebug on Small Phone API 29, Medium Phone API 34, Physical Device API 33.

Behavior after the fix on API 30 and above:
screen_record.mp4

Behavior after the fix on API 29 and below:
screen_record.webm

savsch and others added 2 commits December 13, 2024 17:08
* fix issue6020: prevent unintentional deletion of subfolders and non-images by custom selector
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a folder with sub-folders and .txt file, only the picture in the base folder were deleted, which is great.
Now running the unit tests...

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests passing too.

@nicolas-raoul nicolas-raoul merged commit 8a55b5e into commons-app:main Dec 13, 2024
@nicolas-raoul
Copy link
Member

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if folder to delete contains subfolders
2 participants