Feature: Bookmark Categories

[parneet-guraya]

Fixes #5922

What changes did you make and why?

• Add bookmark button in bookmark details screen.
• Add new bookmark tab in bookmarks screen.

Tests performed (required)

Tested betaDebug on Oneplus 9RT 5G (Android 14)

Screenshots (for UI changes only)

Record_2024-12-16-01-38-04.mp4

[parneet-guraya]

@nicolas-raoul

Hi, I have few questions,

• When logged out we only show bookmark pictures, do we want to show categories too or not when logged out?

• Right now we're loading the entire data. But, do we want to load the items lazily (paging) ? Other bookmarks types (picture, items, locations) does not use paging either.

Obviously that depends on the size of data but do we expect the bookmarks to be in large amounts?

• For the whole bookmark feature (every type) should we have search, sort?

Thanks :)

[nicolas-raoul]

Show when logged out: yes

Paging, sorting, searching: Great idea, though the added complexity would currently not be justified. Would you mind creating a new issue and labeling it as enhancement, low priority? Thanks a lot! 🙂

[parneet-guraya]

Show when logged out: yes

Great! I also kept it that way.

Paging, sorting, searching: Great idea, though the added complexity would currently not be justified. Would you mind creating a new issue and labeling it as enhancement, low priority? Thanks a lot! 🙂

I will shortly, outside right now (commenting from my mobile). :)

[parneet-guraya]

Docs added :)

[nicolas-raoul]

Working great, thanks a lot!

[parneet-guraya]

@nicolas-raoul This closes this #5318 issue as well. Take a look :)