Skip to content

Fix: Allow back button functionality to dismiss language selection dialog #6066 #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

sonalyadav1
Copy link
Contributor

Description:
This pull request addresses an issue where the back button was not functioning correctly after selecting a language for the app UI or description language. When the user selects a language and decides not to proceed, clicking the back button would not navigate them to the previous screen.


Fixes #6066


Changes made:
Implemented a fix to ensure that pressing the back button after selecting the app UI language or description language will return the user to the previous screen.
Ensured that no language selection allows the user to navigate back without issues.


**Tests performed **

1-Tested the back button functionality after selecting and canceling the language selection.
2-Verified that the back button works correctly without applying any language change.

Tested {build variant -testBetaDebugUnitTest} on {Vivo V25} with API level {API 34}.

video_20241223_124352_edit.mp4

@sonalyadav1 sonalyadav1 changed the title Issue #6066 Fix: Allow back button functionality to dismiss language selection dialog #6066 Dec 23, 2024
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@nicolas-raoul nicolas-raoul merged commit 7479767 into commons-app:main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants