Fix crash while uploading #6091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am traveling without a computer this week, but will test next week. Thanks! 🙂 |
|
Trying it now. :-) |
nicolas-raoul
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Not that I was experiencing #6053 very frequently, but at least it has not happened with this branch on a few dozen pictures. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially fixes #6053
and, relates to #6014
I notice that writing chunks to file was copying byte buffers for each of the chunks it was creating during an upload, rather than re-using the buffer that it had. Although Ive not encountered a crash (Pixel 5 / Pixel 9 Pro XL) this is a likely root cause.
Can someone who's seen the problem also test?
Tested on: Pixel 5, Pixel 9 Pro XL