Skip to content

chore : lint fix #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2025
Merged

chore : lint fix #6099

merged 1 commit into from
Jan 5, 2025

Conversation

neeldoshii
Copy link
Contributor

@neeldoshii neeldoshii commented Jan 4, 2025 •
edited
Loading

While working on #6098 I noticed following unused mentioned below.

  • Removed unused constants which were there in Pref
  • Removed unused parameter requireActivity from Settings Fragment

Tag : Low Priority

@neeldoshii neeldoshii marked this pull request as draft January 4, 2025 02:08
@neeldoshii
chore : lint fix
ce4252a 
- Removed unused constants which were there in `Pref`
- Removed unused parameter requireActivity from `Setting Fragment`

Revert "chore : lint fix"

This reverts commit 5992033.
@neeldoshii neeldoshii marked this pull request as ready for review January 4, 2025 02:44
Sujal-Gupta-SG
Sujal-Gupta-SG approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@Sujal-Gupta-SG Sujal-Gupta-SG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by GSoC applicant
The changes made by the contributor, such as the removal of unused variables and libraries, are great and improve code cleanliness.
The app is working fine with these changes, and they enhance the maintainability of the codebase.

@misaochan misaochan merged commit cebe1c2 into commons-app:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaochan misaochan misaochan approved these changes

@Sujal-Gupta-SG Sujal-Gupta-SG Sujal-Gupta-SG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neeldoshii @misaochan @Sujal-Gupta-SG