chore : lint fix #6099
Merged
chore : lint fix #6099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused constants which were there in `Pref` - Removed unused parameter requireActivity from `Setting Fragment` Revert "chore : lint fix" This reverts commit 5992033.
0cbc44d to
ce4252a
Compare
Sujal-Gupta-SG
approved these changes
Jan 4, 2025
Contributor
There was a problem hiding this comment.
Review by GSoC applicant
The changes made by the contributor, such as the removal of unused variables and libraries, are great and improve code cleanliness.
The app is working fine with these changes, and they enhance the maintainability of the codebase.
misaochan
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6098 I noticed following unused mentioned below.
PrefSettings FragmentTag : Low Priority