Rename Constants to Follow Kotlin Naming Conventions #6107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase. >Renamed the following constants in LoginActivity: >saveProgressDialog → SAVE_PROGRESS_DIALOG >saveErrorMessage → SAVE_ERROR_MESSAGE >saveUsername → SAVE_USERNAME >savePassword → SAVE_PASSWORD >Updated all references to these constants throughout the project.
|
Thank you for contributing! Tried performing login everything works! |
neeldoshii
suggested changes
Jan 6, 2025
| <inspection_tool class="PreviewPickerAnnotation" enabled="true" level="ERROR" enabled_by_default="true"> | ||
| <option name="composableFile" value="true" /> | ||
| <option name="previewFile" value="true" /> | ||
| </inspection_tool> |
There was a problem hiding this comment.
Seems like this is local ide changes which can be reverted.
|
Thank you @neeldoshii for pointing this out! I've reverted the IDE-specific file changes and ensured it's excluded from version control. Let me know if there's anything else to address. |
neeldoshii
approved these changes
Jan 6, 2025
Sujal-Gupta-SG
approved these changes
Jan 6, 2025
misaochan
approved these changes
Jan 6, 2025
|
Thanks for reviewing, @neeldoshii . :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase.