Skip to content

Migrated Java profile package to kotlin #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2025
Merged

Migrated Java profile package to kotlin #6119

merged 4 commits into from
Jan 16, 2025

Conversation

Sujal-Gupta-SG
Copy link
Contributor

@Sujal-Gupta-SG Sujal-Gupta-SG commented Jan 11, 2025 •
edited by psh
Loading

Description (required)

Parent Issue #5928
Fixes #6118

What changes did you make and why?
Migrated Profile Package to Kotlin

@Sujal-Gupta-SG Sujal-Gupta-SG changed the title Converted profile activity.java into profile activity.kt Migrated Java profile package to kotlin Jan 11, 2025
@Sujal-Gupta-SG Sujal-Gupta-SG mentioned this pull request Jan 11, 2025
Open
@neeldoshii
Copy link
Contributor

neeldoshii commented Jan 11, 2025 •
edited
Loading

Thanks for contributing Sujal :) Seems like the below test-cases are failing. Can you try fixing it If you need help with it lmk .

e: file:///home/runner/work/apps-android-commons/apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/profile/ProfileActivityTest.kt:53:18 Cannot access 'onDestroy': it is protected in 'ProfileActivity'

e: file:///home/runner/work/apps-android-commons/apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/profile/ProfileActivityTest.kt:112:32 Cannot access 'binding': it is private in 'ProfileActivity'
> Task :app:compileBetaDebugUnitTestKotlin FAILED

@Sujal-Gupta-SG
Copy link
Contributor Author

@neeldoshii can you check it again and tell me iis the error coming again

@Sujal-Gupta-SG
Copy link
Contributor Author

@nicolas-raoul Can you check this pull request also

nicolas-raoul
nicolas-raoul approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, thanks Sujal! :-)

@nicolas-raoul nicolas-raoul merged commit 70291a0 into commons-app:main Jan 16, 2025
1 check passed
@Sujal-Gupta-SG Sujal-Gupta-SG deleted the Converted-ProfileActivity.java-into-ProfileActivity.kt branch January 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Profile Package to Kotlin
3 participants
@Sujal-Gupta-SG @neeldoshii @nicolas-raoul